-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(worker,cdn): logs order #5939
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fsamin
requested review from
richardlt,
sguiheux and
yesnault
as code owners
September 17, 2021 09:46
yesnault
approved these changes
Sep 17, 2021
sguiheux
approved these changes
Sep 17, 2021
* read stdout and stderr in the same goroutine to avoid mixing logs * store the number of millisecond for each line of logs as score in redis and retrieve it in "Number" field from a log line in the UI Signed-off-by: francois samin <francois.samin@corp.ovh.com>
Signed-off-by: francois samin <francois.samin@corp.ovh.com>
fsamin
force-pushed
the
fix/worker/logs_order
branch
from
September 23, 2021 07:23
573a711
to
177cc42
Compare
CDS Report build-all-cds#16527.0 ✘
|
Signed-off-by: francois samin <francois.samin@corp.ovh.com>
CDS Report build-all-cds#16528.0 ✘
|
richardlt
approved these changes
Sep 23, 2021
sguiheux
approved these changes
Sep 23, 2021
CDS Report build-all-cds#16532.0 ✘
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(worker,cdn): logs order
Signed-off-by: francois samin francois.samin@corp.ovh.com